fix: Replace PAUSE with message syntax (not supported in DOS 6.22)

Issue: DOS 6.22 PAUSE command does not accept message text as parameter.
The syntax "PAUSE message..." is a Windows NT/2000+ feature that causes
command-line parameters (%1, %2, etc.) to be consumed/lost in DOS 6.22.

Root cause: User ran "T:\DEPLOY.BAT TS-4R" but script reported
"Machine name not provided". The parameter %1 was being consumed by
the invalid PAUSE syntax at line 31 before reaching GET_MACHINE_NAME.

Changes:
- Fixed 46 PAUSE commands across 9 BAT files
- Converted "PAUSE message..." to "ECHO message..." + "PAUSE"
- Updated check-dos-compatibility.ps1 to detect PAUSE with message
- Created fix-pause-syntax.ps1 automated fix script

Example fix:
BEFORE (Windows NT+ syntax, causes parameter loss):
  PAUSE Press any key to continue...

AFTER (DOS 6.22 compatible):
  ECHO Press any key to continue...
  PAUSE

DOS 6.22 PAUSE command:
- Syntax: PAUSE (no parameters)
- Displays: "Press any key to continue..."
- Cannot customize message (built-in text only)

Files modified:
- DEPLOY.BAT: 10 PAUSE commands fixed
- UPDATE.BAT: 7 PAUSE commands fixed
- CTONW.BAT: 8 PAUSE commands fixed
- NWTOC.BAT: 6 PAUSE commands fixed
- REBOOT.BAT: 4 PAUSE commands fixed
- STAGE.BAT: 6 PAUSE commands fixed
- CHECKUPD.BAT: 2 PAUSE commands fixed
- DOSTEST.BAT: 2 PAUSE commands fixed
- AUTOEXEC.BAT: 1 PAUSE command fixed

Deployed to:
- D2TESTNAS: /data/test/*.BAT (9,908 bytes for DEPLOY.BAT)

Testing: Should now correctly receive command-line parameter:
  T:\DEPLOY.BAT TS-4R

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
2026-01-19 17:19:44 -07:00
parent e040cc99ff
commit 3b55cf1312
11 changed files with 154 additions and 46 deletions

View File

@@ -36,7 +36,8 @@ ECHO Then reboot or run:
ECHO SET MACHINE=TS-4R
ECHO CTONW
ECHO.
PAUSE Press any key to exit...
ECHO Press any key to exit...
PAUSE
GOTO END
REM ==================================================================
@@ -69,7 +70,8 @@ ECHO.
ECHO Or map manually:
ECHO NET USE T: \\D2TESTNAS\test /YES
ECHO.
PAUSE Press any key to exit...
ECHO Press any key to exit...
PAUSE
GOTO END
REM ==================================================================
@@ -120,7 +122,8 @@ ECHO.
ECHO No files were uploaded to COMMON.
ECHO To upload to machine-specific location, run: CTONW
ECHO.
PAUSE Press any key to exit...
ECHO Press any key to exit...
PAUSE
GOTO END
REM ==================================================================
@@ -152,7 +155,8 @@ ECHO [ERROR] C:\BAT directory not found
ECHO.
ECHO No files to upload.
ECHO.
PAUSE Press any key to exit...
ECHO Press any key to exit...
PAUSE
GOTO END
REM ==================================================================
@@ -313,7 +317,8 @@ ECHO - Sufficient disk space on T:
ECHO - Network connection is stable
ECHO - Permissions to create directories
ECHO.
PAUSE Press any key to exit...
ECHO Press any key to exit...
PAUSE
GOTO END
:LOGS_DIR_ERROR
@@ -327,7 +332,8 @@ ECHO - Sufficient disk space on T:
ECHO - Network connection is stable
ECHO - Permissions to create directories
ECHO.
PAUSE Press any key to exit...
ECHO Press any key to exit...
PAUSE
GOTO END
:UPLOAD_ERROR_INIT
@@ -340,7 +346,8 @@ ECHO - Invalid path
ECHO - Target drive not accessible
ECHO - Network connection lost
ECHO.
PAUSE Press any key to exit...
ECHO Press any key to exit...
PAUSE
GOTO END
:UPLOAD_ERROR_USER
@@ -350,7 +357,8 @@ ECHO.
ECHO Upload may be incomplete!
ECHO Run CTONW again to complete upload.
ECHO.
PAUSE Press any key to exit...
ECHO Press any key to exit...
PAUSE
GOTO END
REM ==================================================================