sync: auto-sync from HOWARD-HOME at 2026-05-31 22:31:14

Author: Howard Enos
Machine: HOWARD-HOME
Timestamp: 2026-05-31 22:31:14
This commit is contained in:
2026-05-31 22:31:25 -07:00
parent 22b221cf42
commit 49fa8e264b

View File

@@ -279,3 +279,49 @@ Both merged cleanly; Howard explicitly directed fixing BUG-015 despite the usual
### Reference Information
- PRs: #34 (a11y, merge 4923e9f), #35 (BUG-015, merge 4bca9f3, .ico commit 07d14bd). Root bump 424d610. gururmm main tip 4bca9f3.
- Coord: dashboard component v0.2.36; todo 15a5440f done; todo a47884d7 (gate fix, mike). PLUTO agent 07a11ece.
---
## Update: 22:30 MST — BUG-015 validated on real Win11 + DisplayIcon follow-up shipped
### User
- **User:** Howard Enos (howard)
- **Machine:** Howard-Home
- **Role:** tech
### Session Summary
Tested the BUG-015 ARP MSI on Howard's RMM-TEST-MACHINE (Win11 Enterprise Eval 22621, agent 99d6d692) via the gururmm RMM agent. Recon first confirmed the bug: agent 0.6.50 running (GuruRMMAgent + GuruRMMWatchdog) but NO ARP/Uninstall entry. Installed the PR #35 base MSI via a decoupled SYSTEM scheduled task (so the agent's own service restart during install wouldn't kill the command; results written to a temp file, then polled). Result: msiexec exit 0, agent now appears in Programs and Features with DisplayName/Publisher/version/URLs/NoModify/NoRepair, uninstallable, agent stayed enrolled.
One gap found: DisplayIcon registry value was EMPTY — ARPPRODUCTICON cached the icon (C:\Windows\Installer\{ProductCode}\GuruRMMIcon.ico) and the .ico installed to Program Files\GuruRMM\, but Windows Installer didn't write DisplayIcon, so no branded icon rendered. Howard chose to fix it.
Follow-up fix (PR #36): added an ArpDisplayIcon component to installer/gururmm-agent.wxs writing DisplayIcon=[#GuruRMMIconFile] under HKLM Uninstall\[ProductCode] (Bitness always64 to match the 64-bit ARP key). Code Review APPROVE WITH NITS (strong sequencing analysis: RegisterProduct doesn't author DisplayIcon in this config so won't clobber ours; applied nit #2 - used the build-time-checked [#GuruRMMIconFile] File reference instead of a literal path; kept .ico target over the exe so the BRANDED icon shows). Merged PR #36 (33d97e1), root pointer bump 22b221c.
Force-rebuilt the MSI on Pluto again (gate skips installer-only changes; emptied last-built-commit-windows, ran build-windows.sh as root; completed v0.6.50 in 618s). msiinfo confirmed the new MSI's Registry table contains the DisplayIcon row (component ArpDisplayIcon). Re-tested on RMM-TEST-MACHINE (uninstall old -> install new -> verify, one decoupled task): msiexec exit 0, DisplayIcon now = C:\Program Files\GuruRMM\gururmm-agent.ico (file exists), agent enrolled. BUG-015 fully validated end-to-end. Cleaned up all test artifacts (scheduled tasks + temp files) on the machine.
Also answered a Howard question mid-stream (not a bug): offline agents showing 0.6.50 - confirmed 0.6.50 has been the agent version since 2026-05-29 (commit 9b34393), today's work never bumped the agent version, and the dashboard correctly shows per-agent last-reported versions (fleet spans 0.6.2 -> 0.6.50, not all forced to latest).
### Key Decisions
- Tested via a decoupled SYSTEM scheduled task writing to a result file, because the install restarts GuruRMMAgent (the very agent executing the command); the file survives the restart and is polled afterward.
- Uninstall-old-then-install-new for the DisplayIcon retest (same version 0.6.50, new ProductCode) to avoid MajorUpgrade same-version ambiguity and get a definitive clean install.
- DisplayIcon points at the installed .ico (not the exe) to render the branded icon; used [#FileId] reference for build-time link checking.
### Configuration Changes
- gururmm: installer/gururmm-agent.wxs +ArpDisplayIcon component (PR #36, merge 33d97e1). Root submodule pointer bump 22b221c.
- Pluto: rebuilt gururmm-agent-base-0.6.50.msi (now includes DisplayIcon reg write), deployed to /var/www/gururmm/downloads/, marked stable. last-built-commit-windows -> 33d97e1.
- RMM-TEST-MACHINE: agent reinstalled from the fixed MSI (test); all temp/test artifacts removed afterward.
### Commands & Outputs
- DisplayIcon retest (RMM-TEST-MACHINE, agent 99d6d692): msiexec_exit=0; DisplayIcon=C:\Program Files\GuruRMM\gururmm-agent.ico (file exists); Publisher=Arizona Computer Guru LLC; agent_service=Running. New ProductCode {A9CAA6D5-FCAA-4FFA-87AC-143E8BB455DC}.
- New MSI Registry table row: ArpDisplayIcon -> Uninstall\[ProductCode]\DisplayIcon = [#GuruRMMIconFile].
- Force build: v0.6.50 in 618s.
### Infrastructure & Servers
- RMM-TEST-MACHINE: Win11 Enterprise Eval build 22621, GuruRMM agent id 99d6d692-99e0-4359-9f9c-f43be89f49e5 (a stale 0.6.38 ghost enrollment 7d3456f5 also exists for the same box).
### Pending / Incomplete Tasks
- Mike (todo a47884d7): extend the build change-gate to watch installer/ so installer-only changes rebuild the MSI without a manual force-build.
- Optional: flip FEATURE_ROADMAP.md BUG-015 status Open -> Fixed (doc PR).
### Reference Information
- PR #36 (DisplayIcon): merge 33d97e1, source commit 9a2245b; root bump 22b221c. gururmm main tip 33d97e1.
- #dev-alerts: build + DisplayIcon-verified alerts posted. Mike messaged (BUG-015 fully done).