From 7d600a0d9f86dd0a45b934b761b7782decd39d6c Mon Sep 17 00:00:00 2001 From: Howard Enos Date: Sat, 30 May 2026 09:49:28 -0700 Subject: [PATCH] sync: auto-sync from HOWARD-HOME at 2026-05-30 09:49:19 Author: Howard Enos Machine: HOWARD-HOME Timestamp: 2026-05-30 09:49:19 --- gururmm-small-fixes.html | 159 ++++++++++++++++++ projects/msp-tools/guru-connect | 2 +- .../2026-05-30-howard-gururmm-small-fixes.md | 55 ++++++ 3 files changed, 215 insertions(+), 1 deletion(-) create mode 100644 gururmm-small-fixes.html create mode 100644 session-logs/2026-05-30-howard-gururmm-small-fixes.md diff --git a/gururmm-small-fixes.html b/gururmm-small-fixes.html new file mode 100644 index 0000000..8e9ceba --- /dev/null +++ b/gururmm-small-fixes.html @@ -0,0 +1,159 @@ + + + + + +GuruRMM — Small Fixes Show Notes + + + +
+
+

GuruRMM — Small Fixes

+
Show notes: quick, well-scoped wins pulled from the roadmap + UI gaps
+
+ Date: 2026-05-30 + Sources: FEATURE_ROADMAP.md, UI_GAPS.md + Scope: sub-day fixes only +
+
+ +

Frontend fixes (React / TS — no server change)

+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
IDFixSizePri
BUG-014Site Detail page has no agent search box — add agentSearch state + filter. Every other list page already has this.~30 minP1
Error boundaryNo ErrorBoundary anywhere — one component throw whites out the whole app. Wrap <AppRoutes> with fallback + reload.~30 minMED
BUG-009Logs.tsx — 3 useQuery calls with no isError handling (errors look like "no results"). Copy the pattern from Clients.tsx:164.~1 hrMED
BUG-0108 pages still missing isError handling (Alerts, AlertTemplates, Commands, Dashboard, Logs, Settings, Sites, Users) — same pattern.~half dayMED
BUG-01114 : any annotations across 6 files — swap to existing typed interfaces / unknown + isAxiosError.~1 hrMED
+ +

Server fixes (Rust)

+ + + + + + + + + + + + + + + + + + + + + + +
IDFixSizePri
BUG-008metrics.rs leaks raw e.to_string() DB errors to clients at 5 sites — route through existing internal_err() helper.~30 minMED
Client rowGET /api/agents/:id hardcodes client_name: None, so AgentDetail's "Client" row never renders — enrich get_agent or drop the field.~1 hrMED
Fleet countsDashboard recomputes counts client-side; /metrics/summary + /agents/stats exist but are unused — wire them or delete.~1 hrLOW
+ +

Other small ones

+ + + + + + + + + + + + + + + + +
IDFixSizePri
BUG-015Agent missing from Programs & Features — WiX-only edit, add ARP properties + product icon. Spec'd in SPEC-011.~1 hrP2
Changelog UIRead-only version-history table on AgentDetail. May need one GET endpoint.~0.5 dayP3
+ +
+ Recommended quick session: knock out BUG-014 + Error boundary + BUG-008 together — + all three are sub-hour (two frontend, one backend), and BUG-014 is a P1 that Howard reported. +
+ +
+ Note: BUG-002 and BUG-006 are already fixed in branch fix/audit-2-remediation but unmerged. + That branch can be reviewed/merged separately if useful. +
+ + +
+ + diff --git a/projects/msp-tools/guru-connect b/projects/msp-tools/guru-connect index d0de888..bb73ba6 160000 --- a/projects/msp-tools/guru-connect +++ b/projects/msp-tools/guru-connect @@ -1 +1 @@ -Subproject commit d0de888dd1a3cb53b67381bd53a6fb6566ac95fd +Subproject commit bb73ba667fcaed07de754194bf748da0ed810b49 diff --git a/session-logs/2026-05-30-howard-gururmm-small-fixes.md b/session-logs/2026-05-30-howard-gururmm-small-fixes.md new file mode 100644 index 0000000..b763d4f --- /dev/null +++ b/session-logs/2026-05-30-howard-gururmm-small-fixes.md @@ -0,0 +1,55 @@ +# Session Log — 2026-05-30 (Howard — GuruRMM small-fixes review) + +## User +- **User:** Howard Enos (howard) +- **Machine:** Howard-Home +- **Role:** tech + +## Session Summary + +Reviewed the GuruRMM roadmap to identify small, well-scoped fixes worth tackling in a short session. Read `projects/msp-tools/guru-rmm/docs/FEATURE_ROADMAP.md` and `docs/UI_GAPS.md` and extracted the sub-day items from the larger feature backlog, sorting by priority and effort. + +Compiled a curated shortlist: five frontend (React/TS) fixes — BUG-014 (Site Detail agent search box, P1, ~30 min), an app-wide React ErrorBoundary, BUG-009 (Logs.tsx isError handling), BUG-010 (8 pages missing isError), BUG-011 (14 `: any` annotations); three Rust server fixes — BUG-008 (metrics.rs leaks raw `e.to_string()` to clients), the AgentDetail "Client" row never rendering (get_agent hardcodes `client_name: None`), and the unused `/metrics/summary` + `/agents/stats` aggregation endpoints; plus BUG-015 (WiX ARP/Programs & Features) and a read-only Changelog UI. Recommended a quick trio: BUG-014 + ErrorBoundary + BUG-008. + +Rendered the shortlist as a standalone dark-themed HTML "show notes" document at the repo root (`gururmm-small-fixes.html`) with color-coded priority pills, then opened it in the default browser at the user's request. No code changes were made to GuruRMM — this was a planning/triage session. + +## Key Decisions + +- Wrote the session log as a Howard-namespaced file (`2026-05-30-howard-gururmm-small-fixes.md`) because `2026-05-30-session.md` already exists and belongs to Mike (different user, different topic), per the same-date namespacing rule. +- Built the HTML as a single self-contained file (inline CSS, no external assets) so it opens offline with no dependencies. +- Did not start any fix in this session — kept it to triage; implementation deferred pending user selection of which items to tackle. + +## Problems Encountered + +None. + +## Configuration Changes + +- **Created:** `gururmm-small-fixes.html` (repo root) — standalone HTML summary of GuruRMM small fixes. +- **Created:** `session-logs/2026-05-30-howard-gururmm-small-fixes.md` (this log). + +## Credentials & Secrets + +None discovered or created. + +## Infrastructure & Servers + +No infrastructure touched. Reference only: GuruRMM server Rust/Axum @ 172.16.3.30:3001, dashboard https://rmm.azcomputerguru.com. + +## Commands & Outputs + +- `Start-Process "C:\claudetools\gururmm-small-fixes.html"` — opened the show notes in the default browser. + +## Pending / Incomplete Tasks + +- Awaiting user selection of which small fix(es) to implement. Recommended trio: **BUG-014** (Site Detail search), **ErrorBoundary**, **BUG-008** (metrics.rs error leak). +- Note: BUG-002 and BUG-006 are already fixed in unmerged branch `fix/audit-2-remediation` — could be reviewed/merged separately. + +## Reference Information + +- Roadmap: `projects/msp-tools/guru-rmm/docs/FEATURE_ROADMAP.md` +- UI gaps: `projects/msp-tools/guru-rmm/docs/UI_GAPS.md` +- Audit report (source of BUG-002…012): `projects/msp-tools/guru-rmm/reports/2026-05-25-rmm-audit-2.md` +- Show notes artifact: `gururmm-small-fixes.html` +- BUG-014 / BUG-013 spec: `docs/specs/SPEC-010-agent-ux-improvements.md` +- BUG-015 spec: `docs/specs/SPEC-011-arp-programs-features-registration.md`