sync: auto-sync from HOWARD-HOME at 2026-06-21 20:36:14

Author: Howard Enos
Machine: HOWARD-HOME
Timestamp: 2026-06-21 20:36:14

session-logs/2026-06/2026-06-21-howard-gururmm-features-audit-submodule-fix.md

@@ -119,3 +119,82 @@ Reworked BUG-018 (PR #41) to the 202+bg design, renumbered SPEC-021's migration
 - Branch tips: BUG-018 `de9b089`, SPEC-021 `9171f84`. BUG-019 built `v0.6.67`, marker `8b5e0dc`.
 - New from Mike (via sync): `gururmm-build` skill, guru-rmm `docs/BUILD.md`, memory `feedback_gururmm_build_verification`; fabb3421 app DELETED (use Exchange Operator b43e7342 for client mail, 1873b1b0 for /mailbox).
 - Coord msgs to GURU-5070: 7a4747b8 (claim), 0c2ae45e (done + SSH flag). Discord DM 1518411100927033464 (build-outage flag).
+
+---
+
+## Update: 20:35 PT — Roadmap verification, BUG-021 correction, BUG-022 fix (watchdog dead code)
+
+### Session Summary
+Continued the roadmap verification pass after compaction. Did a deep functional verification of
+the live GuruRMM system (270 agents / 178 online, metrics flowing ~2531 rows/15 min, alerts with 0
+legacy null dedup_keys, per-agent API endpoints all 200 on a real agent). The one unverified spot
+was `watchdog_events`/`watchdog_alerts` = 0 all-time. Traced both paths end-to-end against
+`origin/main`: the watchdog's REST escalation path (`watchdog-alert`, fires after 3 failed restarts)
+is sound — 0 alerts = healthy fleet. But `watchdog_events` = 0 because the agent **never produces**
+a `WatchdogEvent`: the WS variant was defined + fully server-handled (`insert_watchdog_event` + a
+`watchdog_events` table) yet had no producer, and architecturally couldn't (the watchdog is a
+separate companion process with no WS connection). Dead/orphaned path → filed BUG-022 (LOW).
+
+Mid-session, Howard noted Mike likely fixed the earlier build issues. Re-checked the LIVE build
+marker and found I had been reporting a stale snapshot: the Windows build went **green** at
+2026-06-22 02:19 (`v0.6.67`, `last-built-commit-windows == origin/main 1dce66d`). BUG-021 was
+already **fixed** on main via `1dce66d` (pinned `getrandom 0.3.1` + `zeroize 1.8.1` below
+edition2024 — exactly the dep-pin I had diagnosed + flagged; the fix even reused the BUG-021 label).
+Also on main since the snapshot: BUG-018 (202+bg, `cea87d4`) and the Event Log Watch management UI
+(`0fa65f5`). Corrected the BUG-021 roadmap entry to **Fixed** (`97045ec`).
+
+Then fixed BUG-022. For a LOW dead-code defect, chose option (a) — **remove the orphaned path** —
+over building a new feature (granular watchdog reporting is a product call for Mike). Removed the
+`WatchdogEvent` variant + payload + enum from `agent/src/transport/mod.rs`, the variant + payload
+struct + match arm + `insert_watchdog_event` call from `server/src/ws/mod.rs`, and the
+`watchdog_events::*` re-export from `server/src/db/mod.rs`; gutted `db/watchdog_events.rs` to a
+doc-only stub (keeps the table↔module invariant; left the empty table to avoid a migration-number
+collision with the open PR train). Compile-verified on the build server: `cargo check` clean on
+server (48.9s) + agent (15.7s), no new warnings. Pushed `fix/bug-022-watchdog-event-deadcode`
+(`4eb5054`), opened **PR #45** (code) and **PR #46** (docs: BUG-021/BUG-022 fixed + an RMM thought
+for the REST-based granular-watchdog follow-up). Did not merge — merging the code PR triggers a
+fleet build+deploy, left to Howard/Mike.
+
+### Key Decisions
+- BUG-022 fix = **remove dead code**, not implement granular events. Proportionate for LOW; the
+  feature alternative needs Mike's go (GuruRMM project) and a design (REST producer, since the
+  watchdog has no WS connection). Captured the feature idea in RMM_THOUGHTS instead of discarding it.
+- Left the empty `watchdog_events` table in place (no DROP migration) to avoid colliding with the
+  in-flight PR migration numbers (061/062/063 on open PRs #40-42); flagged for a future consolidated
+  cleanup migration.
+- Kept the code fix branch **code-only** and put the doc status flip on the existing docs branch
+  (disjoint files → no merge conflict between PR #45 and #46).
+- Did not merge either PR — merging code to main = fleet deploy (hard-to-reverse, outward-facing).
+
+### Problems Encountered
+- **Stale build-status reporting (friction, logged):** reported BUG-021 as still-failing from a
+  build-log snapshot; it had already gone green by report time. Same "acted on a point-in-time read"
+  class as the earlier stale-audit-base slip. Fix recorded: re-check the LIVE `last-built-commit`
+  marker vs `origin/main` (and the latest build SUCCESS line, not just the last FAILED line) before
+  asserting build status. `errorlog.md` ref=`stale-audit-base-friction`.
+- **Submodule reset to stale `2e469f1` again:** the initial watchdog grep ran against old code.
+  Re-ran authoritatively with `git grep origin/main` and did all edits in worktrees off `origin/main`
+  + push-by-SHA (the established concurrency-safe pattern).
+- **`cargo: command not found` on non-interactive SSH:** the build server's cargo is under
+  `~/.cargo/bin`; sourcing `~/.cargo/env` fixed it (cargo 1.96 on `.30`).
+
+### Configuration Changes (this update)
+- guru-rmm `fix/bug-022-watchdog-event-deadcode` (`4eb5054`): removed dead WatchdogEvent path across
+  `agent/src/transport/mod.rs`, `server/src/ws/mod.rs`, `server/src/db/mod.rs`,
+  `server/src/db/watchdog_events.rs` (doc-only stub).
+- guru-rmm `docs/bug-021-windows-build` (`487431f`): BUG-021→Fixed + BUG-022 entry→Fixed in
+  `docs/FEATURE_ROADMAP.md`; granular-watchdog-visibility thought appended to `docs/RMM_THOUGHTS.md`.
+- `errorlog.md`: one `--friction` entry (stale build-status reporting).
+
+### Pending / Incomplete (this update)
+- **PR #45** (code) + **PR #46** (docs) await merge by Howard/Mike. Merge #45 before #46. Merging #45
+  = fleet build+deploy.
+- Empty `watchdog_events` table still present — drop in a future consolidated cleanup migration.
+- Granular watchdog visibility (REST `watchdog-event` producer) — RMM_THOUGHTS, Raw, needs Mike's go.
+
+### Reference (this update)
+- BUG-021 fix on main: `1dce66d` (getrandom 0.3.1 + zeroize 1.8.1 pin). BUG-018 on main: `cea87d4`.
+  Event Log Watch UI: `0fa65f5`. Windows build green: `v0.6.67`, marker `1dce66d`, 2026-06-22 02:19.
+- Branch tips: fix `4eb5054`, docs `487431f`. PRs: #45 (code), #46 (docs).
+- Verified live: 270 agents/178 online; REST `watchdog-alert` path sound; `watchdog_events`=0 = dead
+  WS path (no producer).