azcomputerguru/claudetools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
80add06ddab2580b99dd25d98a4a0ee607a84d10
claudetools/DEPLOY.BAT
Mike Swanson 80add06dda fix: Replace double-pipe with intermediate temp files for DOS 6.22 compatibility 
CRITICAL ISSUE FOUND BY CODING AGENT WITH SEQUENTIAL THINKING:

Root cause: Lines 273 and 303 used double-pipe commands with output
redirection, which DOS 6.22 cannot handle reliably:

  TYPE file | FIND /V "A" | FIND /V "B" >> output

This syntax fails silently in DOS 6.22:
- The >> operator may bind to wrong command
- DOS 6.22 cannot properly handle TWO pipes followed by redirection
- Result: Nothing gets appended, or operation fails silently

This explains ALL user-reported issues:
1. "set is still at the end of autoexec" - Line 303 failed, so old
   AUTOEXEC.BAT content was never appended to temp file
2. AUTOEXEC.BAT lost most of its content - Only first 2 lines remained
3. Post-boot scripts couldn't find MACHINE variable

Solution: Use intermediate temp files for multi-step filtering

BEFORE (fails in DOS 6.22):
  TYPE C:\AUTOEXEC.BAT | FIND /V "@ECHO OFF" | FIND /V "SET MACHINE=" >> C:\AUTOEXEC.TMP

AFTER (DOS 6.22 compatible):
  TYPE C:\AUTOEXEC.BAT | FIND /V "@ECHO OFF" > C:\AUTOEXEC.TM1
  TYPE C:\AUTOEXEC.TM1 | FIND /V "SET MACHINE=" > C:\AUTOEXEC.TM2
  TYPE C:\AUTOEXEC.TM2 >> C:\AUTOEXEC.TMP
  DEL C:\AUTOEXEC.TM1
  DEL C:\AUTOEXEC.TM2

Changes:
- DEPLOY.BAT lines 271-278: ADD_MACHINE_VAR section fixed
- DEPLOY.BAT lines 301-315: MACHINE_EXISTS section fixed
- Both sections now use C:\AUTOEXEC.TM1 and C:\AUTOEXEC.TM2 as intermediate files
- check-dos-compatibility.ps1: Added pattern to detect double-pipe with redirect

DOS 6.22 Rule:
- ONE pipe per command line maximum
- Use intermediate files for multi-step filtering
- Never combine multiple pipes with output redirection (>, >>)

Testing: This fix should:
1. Preserve ALL content from original AUTOEXEC.BAT
2. Insert SET MACHINE=%MACHINE% at line 2
3. Remove any old SET MACHINE= lines
4. Make MACHINE variable available to post-boot scripts

Deployed to:
- D2TESTNAS: /data/test/DEPLOY.BAT

Credit: Coding Agent with Sequential Thinking MCP identified root cause

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-01-19 17:59:28 -07:00

391 lines
10 KiB
Batchfile
Raw Blame History

@ECHO OFF
REM DEPLOY.BAT - One-time deployment script for DOS Update System
REM
REM Purpose: Installs the new NWTOC update system on DOS 6.22 machines
REM Location: Run from T:\COMMON\ProdSW\DEPLOY.BAT
REM
REM What this does:
REM 1. Backs up current AUTOEXEC.BAT
REM 2. Prompts for machine name (TS-4R, TS-7A, etc.)
REM 3. Updates AUTOEXEC.BAT with MACHINE variable
REM 4. Copies update batch files to C:\BAT\
REM 5. Runs initial NWTOC to download all updates
REM
REM Version: 1.0 - DOS 6.22 compatible
REM Last modified: 2026-01-19
CLS
REM ==================================================================
REM STEP 1: Get machine name from command line (MUST BE FIRST!)
REM ==================================================================
REM Check if machine name provided as parameter
IF "%1"=="" GOTO MACHINE_NAME_MISSING
REM Save parameter to variable immediately (before anything can consume it)
SET MACHINE=%1
ECHO ==============================================================
ECHO DOS Update System - One-Time Deployment
ECHO ==============================================================
ECHO Machine: %MACHINE%
ECHO ==============================================================
ECHO.
ECHO This script will install the new update system on this machine.
ECHO.
ECHO What will be installed:
ECHO - NWTOC.BAT (Download updates from network)
ECHO - CTONW.BAT (Upload changes to network)
ECHO - UPDATE.BAT (Full system backup)
ECHO - STAGE.BAT (System file staging)
ECHO - REBOOT.BAT (Apply updates on reboot)
ECHO - CHECKUPD.BAT (Check for updates)
ECHO.
PAUSE
ECHO.
GOTO CHECK_T_DRIVE
:MACHINE_NAME_MISSING
ECHO.
ECHO [ERROR] Machine name not provided
ECHO.
ECHO Usage: DEPLOY.BAT machine-name
ECHO Example: DEPLOY.BAT TS-4R
ECHO.
ECHO Machine name must match folder on T: drive.
ECHO Example: If this is TS-4R, T:\TS-4R\ must exist
ECHO.
PAUSE
GOTO END
REM ==================================================================
REM STEP 2: Verify T: drive is accessible
REM ==================================================================
:CHECK_T_DRIVE
ECHO [STEP 2/5] Checking network drive...
ECHO.
DIR T:\ >nul
IF ERRORLEVEL 1 GOTO NO_T_DRIVE
C:
IF NOT EXIST T:\*.* GOTO NO_T_DRIVE
ECHO [OK] T: drive is accessible
ECHO T: = \\D2TESTNAS\test
ECHO.
GOTO CHECK_DEPLOY_FILES
:NO_T_DRIVE
C:
ECHO.
ECHO [ERROR] T: drive not available
ECHO.
ECHO The network drive T: must be mapped to \\D2TESTNAS\test
ECHO.
ECHO Run network startup first:
ECHO C:\NET\STARTNET.BAT
ECHO.
ECHO Or map manually:
ECHO NET USE T: \\D2TESTNAS\test /YES
ECHO.
ECHO Then run DEPLOY.BAT again.
ECHO.
PAUSE
GOTO END
REM ==================================================================
REM STEP 3: Verify deployment files exist on network
REM ==================================================================
:CHECK_DEPLOY_FILES
ECHO [STEP 3/5] Verifying deployment files...
ECHO.
IF NOT EXIST T:\COMMON\ProdSW\NWTOC.BAT GOTO MISSING_FILES
IF NOT EXIST T:\COMMON\ProdSW\CTONW.BAT GOTO MISSING_FILES
IF NOT EXIST T:\COMMON\ProdSW\UPDATE.BAT GOTO MISSING_FILES
IF NOT EXIST T:\COMMON\ProdSW\STAGE.BAT GOTO MISSING_FILES
IF NOT EXIST T:\COMMON\ProdSW\CHECKUPD.BAT GOTO MISSING_FILES
ECHO [OK] All deployment files found on network
ECHO Location: T:\COMMON\ProdSW\
ECHO.
GOTO VERIFY_MACHINE_FOLDER
:MISSING_FILES
ECHO [ERROR] Deployment files not found on network
ECHO.
ECHO Expected location: T:\COMMON\ProdSW\
ECHO.
ECHO Files needed:
ECHO - NWTOC.BAT
ECHO - CTONW.BAT
ECHO - UPDATE.BAT
ECHO - STAGE.BAT
ECHO - CHECKUPD.BAT
ECHO.
ECHO Contact system administrator.
ECHO.
PAUSE
GOTO END
REM ==================================================================
REM STEP 4: Verify machine folder on network
REM ==================================================================
:VERIFY_MACHINE_FOLDER
ECHO [STEP 4/5] Verifying machine folder...
ECHO.
REM Verify machine folder exists on network
ECHO Checking for T:\%MACHINE%\ folder...
IF NOT EXIST T:\%MACHINE%\*.* MD T:\%MACHINE%
IF NOT EXIST T:\%MACHINE%\*.* GOTO MACHINE_FOLDER_ERROR
ECHO [OK] Machine folder ready: T:\%MACHINE%\
ECHO.
GOTO UPDATE_AUTOEXEC
:MACHINE_FOLDER_ERROR
ECHO.
ECHO [ERROR] Could not create machine folder on network
ECHO.
ECHO Check:
ECHO - T: drive is writable
ECHO - Network connection is stable
ECHO - Permissions to create directories
ECHO.
PAUSE
GOTO END
REM ==================================================================
REM STEP 5: Install batch files to C:\BAT
REM ==================================================================
:INSTALL_BATCH_FILES
ECHO [STEP 5/5] Installing batch files...
ECHO.
REM Backup current AUTOEXEC.BAT first
IF NOT EXIST C:\AUTOEXEC.BAT GOTO NO_AUTOEXEC_BACKUP
ECHO Backing up AUTOEXEC.BAT...
COPY C:\AUTOEXEC.BAT C:\AUTOEXEC.SAV >NUL
IF ERRORLEVEL 1 GOTO BACKUP_ERROR
ECHO [OK] Backup created: C:\AUTOEXEC.SAV
GOTO AUTOEXEC_BACKUP_DONE
:NO_AUTOEXEC_BACKUP
ECHO [WARNING] No existing AUTOEXEC.BAT found
:AUTOEXEC_BACKUP_DONE
ECHO.
REM Create C:\BAT directory if it doesn't exist
IF NOT EXIST C:\BAT\*.* MD C:\BAT
IF NOT EXIST C:\BAT\*.* GOTO BAT_DIR_ERROR
ECHO Copying update system files to C:\BAT\...
REM Copy batch files from network to local machine
XCOPY T:\COMMON\ProdSW\NWTOC.BAT C:\BAT\ /Y
IF ERRORLEVEL 4 GOTO COPY_ERROR
ECHO [OK] NWTOC.BAT
XCOPY T:\COMMON\ProdSW\CTONW.BAT C:\BAT\ /Y
IF ERRORLEVEL 4 GOTO COPY_ERROR
ECHO [OK] CTONW.BAT
XCOPY T:\COMMON\ProdSW\UPDATE.BAT C:\BAT\ /Y
IF ERRORLEVEL 4 GOTO COPY_ERROR
ECHO [OK] UPDATE.BAT
XCOPY T:\COMMON\ProdSW\STAGE.BAT C:\BAT\ /Y
IF ERRORLEVEL 4 GOTO COPY_ERROR
ECHO [OK] STAGE.BAT
XCOPY T:\COMMON\ProdSW\CHECKUPD.BAT C:\BAT\ /Y
IF ERRORLEVEL 4 GOTO COPY_ERROR
ECHO [OK] CHECKUPD.BAT
ECHO.
ECHO [OK] All update system files installed
ECHO.
GOTO DEPLOYMENT_COMPLETE
:BACKUP_ERROR
ECHO.
ECHO [ERROR] Could not backup AUTOEXEC.BAT
ECHO.
ECHO Continue anyway? (Y/N)
CHOICE /C:YN /N
IF ERRORLEVEL 2 GOTO END
ECHO.
GOTO UPDATE_AUTOEXEC
:BAT_DIR_ERROR
ECHO.
ECHO [ERROR] Could not create C:\BAT directory
ECHO.
PAUSE
GOTO END
:COPY_ERROR
ECHO.
ECHO [ERROR] Failed to copy files from network
ECHO.
ECHO Check:
ECHO - T: drive is accessible
ECHO - C: drive has free space
ECHO - No file locks on C:\BAT\
ECHO.
PAUSE
GOTO END
REM ==================================================================
REM STEP 4: Update AUTOEXEC.BAT with MACHINE variable
REM ==================================================================
:UPDATE_AUTOEXEC
ECHO [STEP 4/5] Updating AUTOEXEC.BAT...
ECHO.
REM Check if MACHINE variable already exists in AUTOEXEC.BAT
IF NOT EXIST C:\AUTOEXEC.BAT GOTO ADD_MACHINE_VAR
FIND "SET MACHINE=" C:\AUTOEXEC.BAT >NUL
IF NOT ERRORLEVEL 1 GOTO MACHINE_EXISTS
:ADD_MACHINE_VAR
REM Insert MACHINE variable at beginning of AUTOEXEC.BAT (not end!)
REM This ensures it's set before any scripts or commands run
IF NOT EXIST C:\AUTOEXEC.BAT GOTO CREATE_NEW_AUTOEXEC
REM AUTOEXEC.BAT exists - insert SET MACHINE at line 2 (after @ECHO OFF)
REM Use intermediate files - DOS 6.22 cannot handle double pipes with redirection
ECHO @ECHO OFF > C:\AUTOEXEC.TMP
ECHO SET MACHINE=%MACHINE% >> C:\AUTOEXEC.TMP
TYPE C:\AUTOEXEC.BAT | FIND /V "@ECHO OFF" > C:\AUTOEXEC.TM1
TYPE C:\AUTOEXEC.TM1 >> C:\AUTOEXEC.TMP
DEL C:\AUTOEXEC.TM1
COPY C:\AUTOEXEC.TMP C:\AUTOEXEC.BAT >NUL
DEL C:\AUTOEXEC.TMP
GOTO MACHINE_ADD_DONE
:CREATE_NEW_AUTOEXEC
REM No AUTOEXEC.BAT exists - create new one
ECHO @ECHO OFF > C:\AUTOEXEC.BAT
ECHO SET MACHINE=%MACHINE% >> C:\AUTOEXEC.BAT
:MACHINE_ADD_DONE
ECHO [OK] Added to AUTOEXEC.BAT: SET MACHINE=%MACHINE%
ECHO (Inserted at beginning, before other commands)
ECHO.
GOTO INSTALL_BATCH_FILES
:MACHINE_EXISTS
ECHO [INFO] MACHINE variable already exists in AUTOEXEC.BAT
ECHO.
ECHO Current value:
TYPE C:\AUTOEXEC.BAT | FIND "SET MACHINE="
ECHO.
ECHO Updating to: SET MACHINE=%MACHINE%
ECHO.
REM Remove old SET MACHINE= line and insert new one at beginning
REM Use intermediate files - DOS 6.22 cannot handle double pipes with redirection
ECHO @ECHO OFF > C:\AUTOEXEC.TMP
ECHO SET MACHINE=%MACHINE% >> C:\AUTOEXEC.TMP
REM Filter out @ECHO OFF and SET MACHINE= lines in separate steps
TYPE C:\AUTOEXEC.BAT | FIND /V "@ECHO OFF" > C:\AUTOEXEC.TM1
TYPE C:\AUTOEXEC.TM1 | FIND /V "SET MACHINE=" > C:\AUTOEXEC.TM2
TYPE C:\AUTOEXEC.TM2 >> C:\AUTOEXEC.TMP
DEL C:\AUTOEXEC.TM1
DEL C:\AUTOEXEC.TM2
REM Replace original with updated version
COPY C:\AUTOEXEC.TMP C:\AUTOEXEC.BAT >NUL
DEL C:\AUTOEXEC.TMP
ECHO [OK] Updated AUTOEXEC.BAT with new machine name
ECHO (Replaced old value, inserted at beginning)
ECHO.
GOTO INSTALL_BATCH_FILES
:AUTOEXEC_ERROR
ECHO.
ECHO [ERROR] Could not update AUTOEXEC.BAT
ECHO.
ECHO You must manually add this line to C:\AUTOEXEC.BAT:
ECHO SET MACHINE=%MACHINE%
ECHO.
PAUSE
GOTO INSTALL_BATCH_FILES
REM ==================================================================
REM DEPLOYMENT COMPLETE
REM ==================================================================
:DEPLOYMENT_COMPLETE
CLS
ECHO ==============================================================
ECHO Deployment Complete!
ECHO ==============================================================
ECHO.
ECHO The DOS Update System has been installed on this machine.
ECHO.
ECHO Machine name: %MACHINE%
ECHO Backup location: T:\%MACHINE%\BACKUP\
ECHO Update location: T:\COMMON\ProdSW\
ECHO.
ECHO ==============================================================
ECHO Available Commands:
ECHO ==============================================================
ECHO.
ECHO NWTOC - Download updates from network
ECHO CTONW - Upload local changes to network
ECHO UPDATE - Backup entire C: drive to network
ECHO CHECKUPD - Check for available updates
ECHO.
ECHO ==============================================================
ECHO Next Steps:
ECHO ==============================================================
ECHO.
ECHO 1. REBOOT this machine to activate MACHINE variable
ECHO Press Ctrl+Alt+Del to reboot
ECHO.
ECHO 2. After reboot, run NWTOC to download all updates:
ECHO C:\BAT\NWTOC
ECHO.
ECHO 3. Create initial backup:
ECHO C:\BAT\UPDATE
ECHO.
ECHO ==============================================================
ECHO.
ECHO Deployment log saved to: T:\%MACHINE%\DEPLOY.LOG
ECHO.
REM Create deployment log
ECHO Deployment completed: %DATE% %TIME% > T:\%MACHINE%\DEPLOY.LOG
ECHO Machine: %MACHINE% >> T:\%MACHINE%\DEPLOY.LOG
ECHO Files installed to: C:\BAT\ >> T:\%MACHINE%\DEPLOY.LOG
ECHO AUTOEXEC.BAT backup: C:\AUTOEXEC.SAV >> T:\%MACHINE%\DEPLOY.LOG
PAUSE
GOTO END
REM ==================================================================
REM CLEANUP AND EXIT
REM ==================================================================
:END
REM Clean up environment variables
SET MACHINE=
Reference in New Issue View Git Blame Copy Permalink