Files
claudetools/.claude/hooks/task-complete
Mike Swanson 359c2cf1b4 Fix zombie process accumulation and broken context recall (Phase 1 - Emergency Fixes)
CRITICAL: This commit fixes both the zombie process issue AND the broken
context recall system that was failing silently due to encoding errors.

ROOT CAUSES FIXED:
1. Periodic save running every 1 minute (540 processes/hour)
2. Missing timeouts on subprocess calls (hung processes)
3. Background spawning with & (orphaned processes)
4. No mutex lock (overlapping executions)
5. Missing UTF-8 encoding in log functions (BREAKING context saves)

FIXES IMPLEMENTED:

Fix 1.1 - Reduce Periodic Save Frequency (80% reduction)
  - File: .claude/hooks/setup_periodic_save.ps1
  - Change: RepetitionInterval 1min -> 5min
  - Impact: 540 -> 108 processes/hour from periodic saves

Fix 1.2 - Add Subprocess Timeouts (prevent hangs)
  - Files: periodic_save_check.py (3 calls), periodic_context_save.py (4 calls)
  - Change: Added timeout=5 to all subprocess.run() calls
  - Impact: Prevents indefinitely hung git/ssh processes

Fix 1.3 - Remove Background Spawning (eliminate orphans)
  - Files: user-prompt-submit (line 68), task-complete (lines 171, 178)
  - Change: Removed & from sync-contexts spawning, made synchronous
  - Impact: Eliminates 290 orphaned processes/hour

Fix 1.4 - Add Mutex Lock (prevent overlaps)
  - File: periodic_save_check.py
  - Change: Added acquire_lock()/release_lock() with try/finally
  - Impact: Prevents Task Scheduler from spawning overlapping instances

Fix 1.5 - Add UTF-8 Encoding (CRITICAL - enables context saves)
  - Files: periodic_context_save.py, periodic_save_check.py
  - Change: Added encoding="utf-8" to all log file opens
  - Impact: FIXES silent failure preventing ALL context saves since deployment

TOOLS ADDED:
  - monitor_zombies.ps1: PowerShell script to track process counts and memory

EXPECTED RESULTS:
  - Before: 1,010 processes/hour, 3-7 GB RAM/hour
  - After: ~151 processes/hour (85% reduction), minimal RAM growth
  - Context recall: NOW WORKING (was completely broken)

TESTING:
  - Run monitor_zombies.ps1 before and after 30min work session
  - Verify context auto-injection on Claude Code restart
  - Check .claude/periodic-save.log for successful saves (no encoding errors)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-01-17 13:51:22 -07:00

183 lines
5.5 KiB
Bash

#!/bin/bash
#
# Claude Code Hook: task-complete (v2 - with offline support)
# Runs AFTER a task is completed
# Saves conversation context to the database for future recall
# FALLBACK: Queues locally when API is unavailable, syncs later
#
# Expected environment variables:
# CLAUDE_PROJECT_ID - UUID of the current project
# JWT_TOKEN - Authentication token for API
# CLAUDE_API_URL - API base URL (default: http://172.16.3.30:8001)
# CONTEXT_RECALL_ENABLED - Set to "false" to disable (default: true)
# TASK_SUMMARY - Summary of completed task (auto-generated by Claude)
# TASK_FILES - Files modified during task (comma-separated)
#
# Load configuration if exists
CONFIG_FILE="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)/context-recall-config.env"
if [ -f "$CONFIG_FILE" ]; then
source "$CONFIG_FILE"
fi
# Default values
API_URL="${CLAUDE_API_URL:-http://172.16.3.30:8001}"
ENABLED="${CONTEXT_RECALL_ENABLED:-true}"
# Local storage paths
CLAUDE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
QUEUE_DIR="$CLAUDE_DIR/context-queue"
PENDING_DIR="$QUEUE_DIR/pending"
UPLOADED_DIR="$QUEUE_DIR/uploaded"
# Exit early if disabled
if [ "$ENABLED" != "true" ]; then
exit 0
fi
# Detect project ID (same logic as user-prompt-submit)
if [ -z "$CLAUDE_PROJECT_ID" ]; then
PROJECT_ID=$(git config --local claude.projectid 2>/dev/null)
if [ -z "$PROJECT_ID" ]; then
GIT_REMOTE=$(git config --get remote.origin.url 2>/dev/null)
if [ -n "$GIT_REMOTE" ]; then
PROJECT_ID=$(echo -n "$GIT_REMOTE" | md5sum | cut -d' ' -f1)
fi
fi
else
PROJECT_ID="$CLAUDE_PROJECT_ID"
fi
# Exit if no project ID
if [ -z "$PROJECT_ID" ]; then
exit 0
fi
# Create queue directories if they don't exist
mkdir -p "$PENDING_DIR" "$UPLOADED_DIR" 2>/dev/null
# Gather task information
TIMESTAMP=$(date -u +"%Y-%m-%dT%H:%M:%SZ")
TIMESTAMP_FILENAME=$(date -u +"%Y%m%d_%H%M%S")
GIT_BRANCH=$(git rev-parse --abbrev-ref HEAD 2>/dev/null || echo "unknown")
GIT_COMMIT=$(git rev-parse --short HEAD 2>/dev/null || echo "none")
# Get recent git changes
CHANGED_FILES=$(git diff --name-only HEAD~1 2>/dev/null | head -10 | tr '\n' ',' | sed 's/,$//')
if [ -z "$CHANGED_FILES" ]; then
CHANGED_FILES="${TASK_FILES:-}"
fi
# Create task summary
if [ -z "$TASK_SUMMARY" ]; then
# Generate basic summary from git log if no summary provided
TASK_SUMMARY=$(git log -1 --pretty=format:"%s" 2>/dev/null || echo "Task completed")
fi
# Build context payload
CONTEXT_TITLE="Session: ${TIMESTAMP}"
CONTEXT_TYPE="session_summary"
RELEVANCE_SCORE=7.0
# Create dense summary
DENSE_SUMMARY="Task completed on branch '${GIT_BRANCH}' (commit: ${GIT_COMMIT}).
Summary: ${TASK_SUMMARY}
Modified files: ${CHANGED_FILES:-none}
Timestamp: ${TIMESTAMP}"
# Escape JSON strings
escape_json() {
echo "$1" | python3 -c "import sys, json; print(json.dumps(sys.stdin.read())[1:-1])"
}
ESCAPED_TITLE=$(escape_json "$CONTEXT_TITLE")
ESCAPED_SUMMARY=$(escape_json "$DENSE_SUMMARY")
# Save context to database
CONTEXT_PAYLOAD=$(cat <<EOF
{
"project_id": "${PROJECT_ID}",
"context_type": "${CONTEXT_TYPE}",
"title": ${ESCAPED_TITLE},
"dense_summary": ${ESCAPED_SUMMARY},
"relevance_score": ${RELEVANCE_SCORE},
"metadata": {
"git_branch": "${GIT_BRANCH}",
"git_commit": "${GIT_COMMIT}",
"files_modified": "${CHANGED_FILES}",
"timestamp": "${TIMESTAMP}"
}
}
EOF
)
# Update project state
PROJECT_STATE_PAYLOAD=$(cat <<EOF
{
"project_id": "${PROJECT_ID}",
"state_data": {
"last_task_completion": "${TIMESTAMP}",
"last_git_commit": "${GIT_COMMIT}",
"last_git_branch": "${GIT_BRANCH}",
"recent_files": "${CHANGED_FILES}"
},
"state_type": "task_completion"
}
EOF
)
# Try to POST to API if we have a JWT token
API_SUCCESS=false
if [ -n "$JWT_TOKEN" ]; then
RESPONSE=$(curl -s --max-time 5 -w "\n%{http_code}" \
-X POST "${API_URL}/api/conversation-contexts" \
-H "Authorization: Bearer ${JWT_TOKEN}" \
-H "Content-Type: application/json" \
-d "$CONTEXT_PAYLOAD" 2>/dev/null)
HTTP_CODE=$(echo "$RESPONSE" | tail -n1)
RESPONSE_BODY=$(echo "$RESPONSE" | sed '$d')
if [ "$HTTP_CODE" = "200" ] || [ "$HTTP_CODE" = "201" ]; then
API_SUCCESS=true
# Also update project state
curl -s --max-time 5 \
-X POST "${API_URL}/api/project-states" \
-H "Authorization: Bearer ${JWT_TOKEN}" \
-H "Content-Type: application/json" \
-d "$PROJECT_STATE_PAYLOAD" 2>/dev/null >/dev/null
fi
fi
# If API call failed, queue locally
if [ "$API_SUCCESS" = "false" ]; then
# Save context to pending queue
QUEUE_FILE="$PENDING_DIR/${PROJECT_ID}_${TIMESTAMP_FILENAME}_context.json"
echo "$CONTEXT_PAYLOAD" > "$QUEUE_FILE"
# Save project state to pending queue
STATE_QUEUE_FILE="$PENDING_DIR/${PROJECT_ID}_${TIMESTAMP_FILENAME}_state.json"
echo "$PROJECT_STATE_PAYLOAD" > "$STATE_QUEUE_FILE"
echo "[WARNING] Context queued locally (API unavailable) - will sync when online" >&2
# Try to sync (opportunistic) - Changed from background (&) to synchronous to prevent zombie processes
if [ -n "$JWT_TOKEN" ]; then
bash "$(dirname "${BASH_SOURCE[0]}")/sync-contexts" >/dev/null 2>&1
fi
else
echo "[OK] Context saved to database" >&2
# Trigger sync of any queued items - Changed from background (&) to synchronous to prevent zombie processes
if [ -n "$JWT_TOKEN" ]; then
bash "$(dirname "${BASH_SOURCE[0]}")/sync-contexts" >/dev/null 2>&1
fi
fi
exit 0