Fix viewer-only installs registering as agents

Previously, any installation with the protocol handler registered
would default to running as an agent. This caused admin/technician
machines (viewer-only) to appear in the sessions list.

Changes:
- Add Config::has_agent_config() to check for explicit agent config
- Only run as agent when: explicit 'agent' command, support code
  provided, OR agent config file exists
- Viewer-only installs (protocol handler but no config) now exit
  silently when launched without arguments

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
2025-12-30 10:10:10 -07:00
parent 4e5328fe4a
commit 0387295401
2 changed files with 38 additions and 4 deletions

View File

@@ -105,6 +105,31 @@ impl Default for EncodingConfig {
} }
impl Config { impl Config {
/// Check if an explicit agent configuration file exists
/// This returns true only if there's a real config file, not generated defaults
pub fn has_agent_config() -> bool {
// Check for config in current directory
let local_config = PathBuf::from("guruconnect.toml");
if local_config.exists() {
return true;
}
// Check in program data directory (Windows)
#[cfg(windows)]
{
if let Ok(program_data) = std::env::var("ProgramData") {
let path = PathBuf::from(program_data)
.join("GuruConnect")
.join("agent.toml");
if path.exists() {
return true;
}
}
}
false
}
/// Load configuration from file or environment /// Load configuration from file or environment
pub fn load() -> Result<Self> { pub fn load() -> Result<Self> {
// Try loading from config file // Try loading from config file

View File

@@ -221,14 +221,23 @@ fn main() -> Result<()> {
if let Some(code) = cli.support_code { if let Some(code) = cli.support_code {
run_agent_mode(Some(code)) run_agent_mode(Some(code))
} else { } else {
// No args: check if protocol handler is installed // No args: check what mode to run
// If not, run install mode (user likely downloaded from web)
if !install::is_protocol_handler_registered() { if !install::is_protocol_handler_registered() {
// Protocol handler not registered - user likely downloaded from web
// Run installer to set up protocol handler
info!("Protocol handler not registered, running installer"); info!("Protocol handler not registered, running installer");
run_install(false) run_install(false)
} else { } else if config::Config::has_agent_config() {
// Protocol handler exists, run as agent // Protocol handler exists AND agent config exists
// This is an agent installation - run as agent
info!("Agent config found, running as agent");
run_agent_mode(None) run_agent_mode(None)
} else {
// Protocol handler exists but NO agent config
// This is a viewer-only installation - just exit silently
// The protocol handler will launch the viewer when needed
info!("Viewer-only installation, exiting (use 'guruconnect agent' to run as agent)");
Ok(())
} }
} }
} }