azcomputerguru/guru-connect
1
0
Fork 0
Code Issues 18 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

[C2] Unauthenticated downloads.rs: hardcoded prod relay URL + default API-key fallback + false support-embedding docstring #11

New Issue
Open
opened 2026-06-05 17:35:00 -07:00 by azcomputerguru · 0 comments
azcomputerguru commented 2026-06-05 17:35:00 -07:00
Owner
Copy Link

Severity: Critical

Component(s): server

Affected file(s):

  • server/src/api/downloads.rs

Problem:
downloads.rs contains a hardcoded production relay URL plus a "managed-agent" default API-key fallback, and a support-download docstring that claims it embeds a value it does not actually embed.

Recommended fix:
Move the URL and key into Config/AppState, have handlers take State, implement (or correct the docstring for) support embedding, and remove the default key.

Remediation phase: P0 (SPEC-019)

From the 2026-06-05 three-way review (Claude+Gemini+Grok) — see reports/review-2026-06-05/SYNTHESIS-three-way.md (finding C2) and REMEDIATION-PLAN.md (P0).

**Severity:** Critical **Component(s):** server **Affected file(s):** - `server/src/api/downloads.rs` **Problem:** `downloads.rs` contains a hardcoded production relay URL plus a "managed-agent" default API-key fallback, and a support-download docstring that claims it embeds a value it does not actually embed. **Recommended fix:** Move the URL and key into `Config`/`AppState`, have handlers take `State`, implement (or correct the docstring for) support embedding, and remove the default key. **Remediation phase:** P0 (SPEC-019) From the 2026-06-05 three-way review (Claude+Gemini+Grok) — see reports/review-2026-06-05/SYNTHESIS-three-way.md (finding C2) and REMEDIATION-PLAN.md (P0).
azcomputerguru added the severity:criticalcomponent:serversecurity labels 2026-06-05 17:35:00 -07:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
component:agent
component:dashboard
component:server
security
severity:critical
severity:high
No Label component:server security severity:critical
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
azcomputerguru
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: azcomputerguru/guru-connect#11
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?