azcomputerguru/guru-connect
1
0
Fork 0
Code Issues 18 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

[C4] Agent block_in_place/Handle::block_on in main async session loop -> thread-starvation/deadlock #13

New Issue
Open
opened 2026-06-05 17:35:11 -07:00 by azcomputerguru · 0 comments
azcomputerguru commented 2026-06-05 17:35:11 -07:00
Owner
Copy Link

Severity: Critical

Component(s): agent

Affected file(s):

  • agent/src/transport/websocket.rs (call site session/mod.rs)

Problem:
The agent calls block_in_place(|| Handle::block_on(...)) in the main async session loop and in viewer recv, creating thread-starvation/deadlock risk, alongside a racy connected flag.

Recommended fix:
Use a dedicated recv task over an mpsc channel, or an async timeout on the locked stream.

Remediation phase: P3 (SPEC-022)

From the 2026-06-05 three-way review (Claude+Gemini+Grok) — see reports/review-2026-06-05/SYNTHESIS-three-way.md (finding C4) and REMEDIATION-PLAN.md (P3).

**Severity:** Critical **Component(s):** agent **Affected file(s):** - `agent/src/transport/websocket.rs` (call site `session/mod.rs`) **Problem:** The agent calls `block_in_place(|| Handle::block_on(...))` in the main async session loop and in viewer recv, creating thread-starvation/deadlock risk, alongside a racy `connected` flag. **Recommended fix:** Use a dedicated recv task over an mpsc channel, or an async timeout on the locked stream. **Remediation phase:** P3 (SPEC-022) From the 2026-06-05 three-way review (Claude+Gemini+Grok) — see reports/review-2026-06-05/SYNTHESIS-three-way.md (finding C4) and REMEDIATION-PLAN.md (P3).
azcomputerguru added the severity:criticalcomponent:agentsecurity labels 2026-06-05 17:35:11 -07:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
component:agent
component:dashboard
component:server
security
severity:critical
severity:high
No Label component:agent security severity:critical
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
azcomputerguru
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: azcomputerguru/guru-connect#13
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?