Mike Swanson
80add06dda
CRITICAL ISSUE FOUND BY CODING AGENT WITH SEQUENTIAL THINKING: Root cause: Lines 273 and 303 used double-pipe commands with output redirection, which DOS 6.22 cannot handle reliably: TYPE file | FIND /V "A" | FIND /V "B" >> output This syntax fails silently in DOS 6.22: - The >> operator may bind to wrong command - DOS 6.22 cannot properly handle TWO pipes followed by redirection - Result: Nothing gets appended, or operation fails silently This explains ALL user-reported issues: 1. "set is still at the end of autoexec" - Line 303 failed, so old AUTOEXEC.BAT content was never appended to temp file 2. AUTOEXEC.BAT lost most of its content - Only first 2 lines remained 3. Post-boot scripts couldn't find MACHINE variable Solution: Use intermediate temp files for multi-step filtering BEFORE (fails in DOS 6.22): TYPE C:\AUTOEXEC.BAT | FIND /V "@ECHO OFF" | FIND /V "SET MACHINE=" >> C:\AUTOEXEC.TMP AFTER (DOS 6.22 compatible): TYPE C:\AUTOEXEC.BAT | FIND /V "@ECHO OFF" > C:\AUTOEXEC.TM1 TYPE C:\AUTOEXEC.TM1 | FIND /V "SET MACHINE=" > C:\AUTOEXEC.TM2 TYPE C:\AUTOEXEC.TM2 >> C:\AUTOEXEC.TMP DEL C:\AUTOEXEC.TM1 DEL C:\AUTOEXEC.TM2 Changes: - DEPLOY.BAT lines 271-278: ADD_MACHINE_VAR section fixed - DEPLOY.BAT lines 301-315: MACHINE_EXISTS section fixed - Both sections now use C:\AUTOEXEC.TM1 and C:\AUTOEXEC.TM2 as intermediate files - check-dos-compatibility.ps1: Added pattern to detect double-pipe with redirect DOS 6.22 Rule: - ONE pipe per command line maximum - Use intermediate files for multi-step filtering - Never combine multiple pipes with output redirection (>, >>) Testing: This fix should: 1. Preserve ALL content from original AUTOEXEC.BAT 2. Insert SET MACHINE=%MACHINE% at line 2 3. Remove any old SET MACHINE= lines 4. Make MACHINE variable available to post-boot scripts Deployed to: - D2TESTNAS: /data/test/DEPLOY.BAT Credit: Coding Agent with Sequential Thinking MCP identified root cause Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
3.5 KiB
3.5 KiB