sync: auto-sync from HOWARD-HOME at 2026-05-30 09:49:19

Author: Howard Enos
Machine: HOWARD-HOME
Timestamp: 2026-05-30 09:49:19
This commit is contained in:
2026-05-30 09:49:28 -07:00
parent 7cb7cde164
commit 7d600a0d9f
3 changed files with 215 additions and 1 deletions

159
gururmm-small-fixes.html Normal file
View File

@@ -0,0 +1,159 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>GuruRMM — Small Fixes Show Notes</title>
<style>
:root {
--bg: #0f1115;
--panel: #171a21;
--panel-2: #1d2129;
--border: #2a2f3a;
--text: #e6e9ef;
--muted: #9aa3b2;
--accent: #4f9cff;
--p1: #ff5d5d;
--med: #ffb84d;
--low: #5ad19a;
--mono: ui-monospace, "Cascadia Code", "SF Mono", Consolas, monospace;
}
* { box-sizing: border-box; }
body {
margin: 0;
font-family: -apple-system, "Segoe UI", Roboto, Helvetica, Arial, sans-serif;
background: var(--bg);
color: var(--text);
line-height: 1.55;
}
.wrap { max-width: 960px; margin: 0 auto; padding: 48px 24px 96px; }
header { border-bottom: 1px solid var(--border); padding-bottom: 24px; margin-bottom: 32px; }
h1 { font-size: 28px; margin: 0 0 6px; letter-spacing: -0.4px; }
.sub { color: var(--muted); font-size: 14px; }
.meta { margin-top: 14px; display: flex; gap: 18px; flex-wrap: wrap; font-size: 13px; color: var(--muted); }
.meta b { color: var(--text); font-weight: 600; }
h2 { font-size: 16px; text-transform: uppercase; letter-spacing: 1px; color: var(--accent); margin: 40px 0 14px; }
table { width: 100%; border-collapse: collapse; background: var(--panel); border: 1px solid var(--border); border-radius: 10px; overflow: hidden; }
th, td { text-align: left; padding: 12px 14px; border-bottom: 1px solid var(--border); vertical-align: top; font-size: 14px; }
th { background: var(--panel-2); font-size: 11px; text-transform: uppercase; letter-spacing: 0.8px; color: var(--muted); }
tr:last-child td { border-bottom: none; }
td.id { font-family: var(--mono); font-size: 13px; white-space: nowrap; color: var(--accent); }
td.size { font-family: var(--mono); font-size: 13px; color: var(--muted); white-space: nowrap; }
.pill { display: inline-block; padding: 2px 9px; border-radius: 999px; font-size: 11px; font-weight: 700; letter-spacing: 0.4px; }
.pill.p1 { background: rgba(255,93,93,0.15); color: var(--p1); border: 1px solid rgba(255,93,93,0.4); }
.pill.med { background: rgba(255,184,77,0.13); color: var(--med); border: 1px solid rgba(255,184,77,0.4); }
.pill.low { background: rgba(90,209,154,0.13); color: var(--low); border: 1px solid rgba(90,209,154,0.4); }
.rec { background: linear-gradient(180deg, var(--panel-2), var(--panel)); border: 1px solid var(--border); border-left: 3px solid var(--accent); border-radius: 10px; padding: 18px 20px; margin-top: 16px; }
.rec b { color: var(--accent); }
code { font-family: var(--mono); font-size: 12.5px; background: var(--panel-2); padding: 1px 6px; border-radius: 5px; color: #cdd6e4; }
.note { color: var(--muted); font-size: 13px; margin-top: 28px; padding-top: 18px; border-top: 1px solid var(--border); }
footer { margin-top: 48px; color: var(--muted); font-size: 12px; text-align: center; }
</style>
</head>
<body>
<div class="wrap">
<header>
<h1>GuruRMM &mdash; Small Fixes</h1>
<div class="sub">Show notes: quick, well-scoped wins pulled from the roadmap + UI gaps</div>
<div class="meta">
<span><b>Date:</b> 2026-05-30</span>
<span><b>Sources:</b> FEATURE_ROADMAP.md, UI_GAPS.md</span>
<span><b>Scope:</b> sub-day fixes only</span>
</div>
</header>
<h2>Frontend fixes (React / TS &mdash; no server change)</h2>
<table>
<thead><tr><th>ID</th><th>Fix</th><th>Size</th><th>Pri</th></tr></thead>
<tbody>
<tr>
<td class="id">BUG-014</td>
<td>Site Detail page has no agent search box &mdash; add <code>agentSearch</code> state + filter. Every other list page already has this.</td>
<td class="size">~30 min</td>
<td><span class="pill p1">P1</span></td>
</tr>
<tr>
<td class="id">Error boundary</td>
<td>No <code>ErrorBoundary</code> anywhere &mdash; one component throw whites out the whole app. Wrap <code>&lt;AppRoutes&gt;</code> with fallback + reload.</td>
<td class="size">~30 min</td>
<td><span class="pill med">MED</span></td>
</tr>
<tr>
<td class="id">BUG-009</td>
<td><code>Logs.tsx</code> &mdash; 3 <code>useQuery</code> calls with no <code>isError</code> handling (errors look like "no results"). Copy the pattern from <code>Clients.tsx:164</code>.</td>
<td class="size">~1 hr</td>
<td><span class="pill med">MED</span></td>
</tr>
<tr>
<td class="id">BUG-010</td>
<td>8 pages still missing <code>isError</code> handling (Alerts, AlertTemplates, Commands, Dashboard, Logs, Settings, Sites, Users) &mdash; same pattern.</td>
<td class="size">~half day</td>
<td><span class="pill med">MED</span></td>
</tr>
<tr>
<td class="id">BUG-011</td>
<td>14 <code>: any</code> annotations across 6 files &mdash; swap to existing typed interfaces / <code>unknown</code> + <code>isAxiosError</code>.</td>
<td class="size">~1 hr</td>
<td><span class="pill med">MED</span></td>
</tr>
</tbody>
</table>
<h2>Server fixes (Rust)</h2>
<table>
<thead><tr><th>ID</th><th>Fix</th><th>Size</th><th>Pri</th></tr></thead>
<tbody>
<tr>
<td class="id">BUG-008</td>
<td><code>metrics.rs</code> leaks raw <code>e.to_string()</code> DB errors to clients at 5 sites &mdash; route through existing <code>internal_err()</code> helper.</td>
<td class="size">~30 min</td>
<td><span class="pill med">MED</span></td>
</tr>
<tr>
<td class="id">Client row</td>
<td><code>GET /api/agents/:id</code> hardcodes <code>client_name: None</code>, so AgentDetail's "Client" row never renders &mdash; enrich <code>get_agent</code> or drop the field.</td>
<td class="size">~1 hr</td>
<td><span class="pill med">MED</span></td>
</tr>
<tr>
<td class="id">Fleet counts</td>
<td>Dashboard recomputes counts client-side; <code>/metrics/summary</code> + <code>/agents/stats</code> exist but are unused &mdash; wire them or delete.</td>
<td class="size">~1 hr</td>
<td><span class="pill low">LOW</span></td>
</tr>
</tbody>
</table>
<h2>Other small ones</h2>
<table>
<thead><tr><th>ID</th><th>Fix</th><th>Size</th><th>Pri</th></tr></thead>
<tbody>
<tr>
<td class="id">BUG-015</td>
<td>Agent missing from Programs &amp; Features &mdash; WiX-only edit, add ARP properties + product icon. Spec'd in SPEC-011.</td>
<td class="size">~1 hr</td>
<td><span class="pill med">P2</span></td>
</tr>
<tr>
<td class="id">Changelog UI</td>
<td>Read-only version-history table on AgentDetail. May need one <code>GET</code> endpoint.</td>
<td class="size">~0.5 day</td>
<td><span class="pill low">P3</span></td>
</tr>
</tbody>
</table>
<div class="rec">
<b>Recommended quick session:</b> knock out <b>BUG-014 + Error boundary + BUG-008</b> together &mdash;
all three are sub-hour (two frontend, one backend), and BUG-014 is a P1 that Howard reported.
</div>
<div class="note">
Note: BUG-002 and BUG-006 are already fixed in branch <code>fix/audit-2-remediation</code> but unmerged.
That branch can be reviewed/merged separately if useful.
</div>
<footer>GuruRMM &middot; Arizona Computer Guru &middot; generated 2026-05-30</footer>
</div>
</body>
</html>

View File

@@ -0,0 +1,55 @@
# Session Log — 2026-05-30 (Howard — GuruRMM small-fixes review)
## User
- **User:** Howard Enos (howard)
- **Machine:** Howard-Home
- **Role:** tech
## Session Summary
Reviewed the GuruRMM roadmap to identify small, well-scoped fixes worth tackling in a short session. Read `projects/msp-tools/guru-rmm/docs/FEATURE_ROADMAP.md` and `docs/UI_GAPS.md` and extracted the sub-day items from the larger feature backlog, sorting by priority and effort.
Compiled a curated shortlist: five frontend (React/TS) fixes — BUG-014 (Site Detail agent search box, P1, ~30 min), an app-wide React ErrorBoundary, BUG-009 (Logs.tsx isError handling), BUG-010 (8 pages missing isError), BUG-011 (14 `: any` annotations); three Rust server fixes — BUG-008 (metrics.rs leaks raw `e.to_string()` to clients), the AgentDetail "Client" row never rendering (get_agent hardcodes `client_name: None`), and the unused `/metrics/summary` + `/agents/stats` aggregation endpoints; plus BUG-015 (WiX ARP/Programs & Features) and a read-only Changelog UI. Recommended a quick trio: BUG-014 + ErrorBoundary + BUG-008.
Rendered the shortlist as a standalone dark-themed HTML "show notes" document at the repo root (`gururmm-small-fixes.html`) with color-coded priority pills, then opened it in the default browser at the user's request. No code changes were made to GuruRMM — this was a planning/triage session.
## Key Decisions
- Wrote the session log as a Howard-namespaced file (`2026-05-30-howard-gururmm-small-fixes.md`) because `2026-05-30-session.md` already exists and belongs to Mike (different user, different topic), per the same-date namespacing rule.
- Built the HTML as a single self-contained file (inline CSS, no external assets) so it opens offline with no dependencies.
- Did not start any fix in this session — kept it to triage; implementation deferred pending user selection of which items to tackle.
## Problems Encountered
None.
## Configuration Changes
- **Created:** `gururmm-small-fixes.html` (repo root) — standalone HTML summary of GuruRMM small fixes.
- **Created:** `session-logs/2026-05-30-howard-gururmm-small-fixes.md` (this log).
## Credentials & Secrets
None discovered or created.
## Infrastructure & Servers
No infrastructure touched. Reference only: GuruRMM server Rust/Axum @ 172.16.3.30:3001, dashboard https://rmm.azcomputerguru.com.
## Commands & Outputs
- `Start-Process "C:\claudetools\gururmm-small-fixes.html"` — opened the show notes in the default browser.
## Pending / Incomplete Tasks
- Awaiting user selection of which small fix(es) to implement. Recommended trio: **BUG-014** (Site Detail search), **ErrorBoundary**, **BUG-008** (metrics.rs error leak).
- Note: BUG-002 and BUG-006 are already fixed in unmerged branch `fix/audit-2-remediation` — could be reviewed/merged separately.
## Reference Information
- Roadmap: `projects/msp-tools/guru-rmm/docs/FEATURE_ROADMAP.md`
- UI gaps: `projects/msp-tools/guru-rmm/docs/UI_GAPS.md`
- Audit report (source of BUG-002…012): `projects/msp-tools/guru-rmm/reports/2026-05-25-rmm-audit-2.md`
- Show notes artifact: `gururmm-small-fixes.html`
- BUG-014 / BUG-013 spec: `docs/specs/SPEC-010-agent-ux-improvements.md`
- BUG-015 spec: `docs/specs/SPEC-011-arp-programs-features-registration.md`